Feat: add oauth2 support for Jira toolkit #30684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eyurtsev
reviewed
Apr 9, 2025
| @@ -14,6 +14,7 @@ class JiraAPIWrapper(BaseModel): | |||
| confluence: Any = None | |||
| jira_username: Optional[str] = None | |||
| jira_api_token: Optional[str] = None | |||
| jira_oauth_dict: Optional[Union[Dict[str, Union[str, Dict[str, str]]], str]] = None | |||
There was a problem hiding this comment.
dictisn't a good thing to put in this variable name. Perhapsjira_oauth2to indicate it's just proxying theoauth2variable?- Could you document inline what values are accepted? And explicit type annotation for the dict using a TypedDict (
typing_extensions import TypedDict) would help! - Now that there's more than one option to authenticate, it would be good to document this as part of the wrapper -- you could add an authentication example in the JiraAPIWrapper and inline a doc-string for both variables
There was a problem hiding this comment.
Is it what you had in mind?
eyurtsev
reviewed
Apr 9, 2025
eyurtsev
approved these changes
Apr 11, 2025
| """Jira OAuth2 token type ('bearer' or other).""" | ||
|
|
||
|
|
||
| class JiraOauth2(TypedDict): |
There was a problem hiding this comment.
typing_extensions.TypedDict might be needed w/ pydantic and python < 3.12
eyurtsev
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: add support for oauth2 in Jira tool by adding the possibility to pass a dictionary with oauth parameters. I also adapted the documentation to show this new behavior